Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1357 +/- ##
===========================================
+ Coverage 87.42% 87.44% +0.02%
===========================================
Files 99 99
Lines 3459 3458 -1
Branches 414 414
===========================================
Hits 3024 3024
+ Misses 365 364 -1
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
…/ServiceX into mshirley/setuptools-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some quality of life changes.
poetry.lockpkg_resourcescalls from code (whichsetuptools==^82removed). Versioningsetuptoolsto 81 will also fix this error, but it is simple enough to remove calls topkg_resources.pre-committodevgroup inpyproject.toml. Obviously this is good practice, but not doing so will now generate an error in the build step due to a compatibility issue withvirtualenv. Moving it to thedevgroup fixes this.